fix: Attempt to send minidumps for all process-gone
reasons
#586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that
webContents.forcefullyCrashRenderer()
results in a minidump being generated butrender-process-gone
notifies that the process waskilled
.We were ignoring all reasons which were not crashes and this resulted in ignoring some minidumps and then sending them on next app start and assuming they came from the main process.
This PR:
exit.reason
in tags so customers can filter them