fix: Also check crashpad pending directory on macOS when renderer process exits
#592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
fix/also-check-crashpad-pending-directory
branch
from
59d5ebb
to
52c4cbd
Compare
timfish
changed the title
pending directory when renderer process exitspending directory on macOS when renderer process exits
AbhiPrasad
approved these changes
Nov 20, 2022
| const files = await readDirAsync(path); | ||
| found.push(...files.map((file) => join(path, file))); | ||
| } catch (_) { | ||
| // |
There was a problem hiding this comment.
should we debug log out something here?
There was a problem hiding this comment.
The catch is to cater for the directory not existing but it doesn't matter if it's missing
There was a problem hiding this comment.
ahh I see, thanks for clarifying, that kinda flew over my head :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #591
On macOS, if you call
webContents.forcefullyCrashRenderer()the resulting minidump ends up in thependingsubdirectory and doesn't get copied to completed until the app restarts. This causes it to be classed as a main process crash.This PR means we now check the
pendingdirectory for minidumps on macOS and adds a test that ensures minidumps are correctly handled when caused bywebContents.forcefullyCrashRenderer().