CI: Automate SDK version updates #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
ci/automate-sdk-update-prs
branch
from
4ef4861 to
3ffb831
Compare
lforst
approved these changes
Jan 6, 2023
| import { join } from 'path'; | ||
| import { fileURLToPath } from 'url'; | ||
|
|
||
| const __dirname = fileURLToPath(new URL('.', import.meta.url)); |
There was a problem hiding this comment.
l: Should we rename this to just dirname so that __dirname isn't overloaded?
There was a problem hiding this comment.
Yeah can do.
I used __dirname here because this code is shimming it as it just doesn't exist in JavaScript modules.
| - name: Update Versions | ||
| run: yarn update-sdk-versions | ||
| - name: Create Pull Request | ||
| uses: peter-evans/create-pull-request@v3 |
There was a problem hiding this comment.
I always wonder if it makes sense to just pin the exact version of actions just to lower the chance of supply chain attacks. Is there anything at risk in this repo?
There was a problem hiding this comment.
I think the only risk is it adding code that is missed in code review and makes it into a release.
We just need to treat PRs created by this like any other from an unknown contributor!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a workflow run every day which submits PRs if the JavaScript SDKs have had new releases.