feat: Support browser Replay in renderers #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Jan 11, 2023
| chunks.push(buf.slice(0, i + 1).toString()); | ||
| buf = buf.slice(i + 1); | ||
| chunks.push(buf.subarray(0, i + 1).toString()); | ||
| buf = buf.subarray(i + 1); |
There was a problem hiding this comment.
I assume we made this change for performance reasons?
There was a problem hiding this comment.
This was to fix a lint warning as slice is now deprecated.
It also happens to be better for perf. as there's no new allocation!
There was a problem hiding this comment.
This was to fix a lint warning as slice is now deprecated.
TIL!
There was a problem hiding this comment.
TIL that Buffer.prototype.slice() is not compatible with the Uint8Array.prototype.slice(), which is a superclass of Buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #606
This PR:
normalizeUrlsInReplayEnvelopeand calls it with envelopes that are passed through the main processThis PR initially failed for lint errors in unchanged files. I ended up needing to:
eslintversion to match the JavaScript monorepo