test: Disable sandbox for Linux e2e tests #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
timfish
force-pushed
the
test/linux-disable-gpu
branch
from
9037370 to
61f407c
Compare
timfish
changed the title
AbhiPrasad
reviewed
Jan 11, 2023
|
|
||
| // Older versions of Electron no longer work correctly on 'ubuntu-latest' with sandbox | ||
| if (process.platform === 'linux') { | ||
| args.push('--no-sandbox'); |
There was a problem hiding this comment.
shouldn't we just do this only for older electron versions? (add a major <= 13)
There was a problem hiding this comment.
Changed so it only disables sandbox for < v13
AbhiPrasad
approved these changes
Jan 11, 2023
|
Hopefully third time lucky getting the release out today 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many older versions of Electron no longer work correctly on
ubuntu-latestfailing with dbus errors and GPU crashes.Disabling sandbox on Linux gets the tests passing without any obvious risk.