Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Normalize filename before parsing module name #699

Merged
merged 2 commits into from
Jul 13, 2023
Merged

fix: Normalize filename before parsing module name #699

merged 2 commits into from
Jul 13, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jul 13, 2023 •
edited
Loading

Closes #686

This PR:

  • Updates to v7.58.0 of the JavaScript SDKs
  • Overrides the stack parser in the main process
    • Normalises the filename before parsing the module name
  • Adds a test to ensure module in the stack frame is correctly set

@timfish timfish marked this pull request as ready for review July 13, 2023 13:58
@timfish timfish requested a review from AbhiPrasad July 13, 2023 14:00
@timfish timfish merged commit 3064e99 into getsentry:master Jul 13, 2023
@timfish timfish mentioned this pull request Jul 13, 2023
Closed
@timfish timfish deleted the fix/normalise-module branch September 28, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Electron - For the module field, exclude anything before .asar/
2 participants
@timfish @AbhiPrasad