-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add integration to track sessions as app in foreground #725
Conversation
8ed2416
to
49a6aa9
Compare
179129e
to
ff6146c
Compare
I've limited this new feature to Electron >= v12 since older versions of Electron seem to unreliably report Electron v12 has been EOL for nearly 2 years now and nobody should be using it for new projects! |
Let me clarify with the mobile SDKs about what they do here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to get a test for errored session as well.
The behaviour we kept here is good to go! |
Closes #712
This PR
BrowserWindowSession
integration which tracks sessions as when the app has focusbackgroundTimeoutSeconds
constructor option.src/main/sessions.ts
since this is now use by both session integrations