-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Re-work Sentry minidump loader #761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
fix/rework-minidump-loader
branch
3 times, most recently
from
October 1, 2023 10:53
c427b78
to
eb1f62b
Compare
timfish
force-pushed
the
fix/rework-minidump-loader
branch
from
October 1, 2023 11:16
eb1f62b
to
b38e05b
Compare
timfish
force-pushed
the
fix/rework-minidump-loader
branch
from
October 1, 2023 23:14
7db467f
to
dfaf18c
Compare
timfish
commented
Oct 1, 2023
timfish
force-pushed
the
fix/rework-minidump-loader
branch
from
October 1, 2023 23:28
dfaf18c
to
329fabb
Compare
timfish
commented
Oct 1, 2023
timfish
force-pushed
the
fix/rework-minidump-loader
branch
from
October 1, 2023 23:49
329fabb
to
380f2cc
Compare
AbhiPrasad
reviewed
Oct 2, 2023
AbhiPrasad
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused at the extra session, but I think we should just ship since it doesn't break anything
My best guess is that the extra session has always been there but we're only seeing it now after extending the app run time to cater for the sending delays added by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #763
This PR re-writes the minidump loading code.
createMinidumpLoader
.Mutex
I had to extend the timings on many of the e2e tests because these changes add a delay in minidump sending while we wait to ensure the file is not being written.