Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with nested LiveViews #733

Closed
tomtaylor opened this issue May 30, 2024 · 2 comments · Fixed by #734
Closed

Error with nested LiveViews #733

tomtaylor opened this issue May 30, 2024 · 2 comments · Fixed by #734
Assignees

Comments

@tomtaylor
Copy link

Environment

LiveView 0.20.12, Sentry 10.6.0.

Steps to Reproduce

  1. Render a page which contains a nested LiveView

Expected Result

It renders.

Actual Result

[error] Sentry.LiveView.on_mount hook errored out: ** (RuntimeError) attempted to read connect_info from a nested child LiveView PoplarWeb.Admin.TaskManagerLive.

Only the root LiveView has access to connect_info.

Then the page rerenders.

@sl0thentr0py
Copy link
Member

sl0thentr0py commented May 31, 2024

thx for the report
we'll have to make sure that we call get_connect_info here only if the socket is not a child by checking parent_pid on the Socket.

@tomtaylor
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants