Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default result type to :none #341

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Conversation

mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented May 8, 2019

elixir-lang/elixir#9028 shows a Sentry bug from #174 in which the current behavior causes messages to build up in the calling process. This is likely primarily affecting processes calling Sentry.capture_exception/1, as Sentry.LoggerBackend will handle the messages on handle_info/2 and Sentry.Plug will generally live in a process that's about to exit.

The default should have been :none all along, so this PR fixes that, and the documentation already discusses the potential issues with :async and Task.Supervisor.async_nolink/2

This closes #360

@mitchellhenke mitchellhenke added this to the 8.0 milestone Jul 17, 2019
@mitchellhenke
Copy link
Contributor Author

Note to myself, we should consider returning the generated ID of the event regardless of the result type to make stuff like #365 easier

@jeroenvisser101
Copy link

@mitchellhenke would love to be able to configure defaults like these. Was looking for a way to change this, as we tried reporting unknown messages to Sentry (which ended up being an infinite loop). Being able to configure this allows it to not require a major release (yet), as the default could stay the same. Either way, we would also prefer to use :none, so configurable or not, we would love to see this in a future version :)

@mitchellhenke
Copy link
Contributor Author

@jeroenvisser101 a configuration for that is possible, but the default needs to change either way due to the inherent issues mentioned in the issue 🙂

@mitchellhenke mitchellhenke merged commit 45f83d6 into master Jun 9, 2020
@mitchellhenke mitchellhenke deleted the change-default-send-behaviour branch June 9, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry not reporting errors because process gets killed
2 participants