Not reading dsn config at compile time #441
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #440.
As described in the bug report, the
:dsn
config value got read at compile time, failing if something else then a value that can be parsed byURI.parse/1
is present.I added a test as well but I'm not 100% happy as it does not confirm that
Sentry.config.dsn/0
is not called at compile time but rather that a call toroot_source_code_paths
does not evaluate thedsn
config variable. Callingget_config
without thecheck_dsn: false
option at compile time somewhere else will result in the same error and is not catched by my test. I'm currently not sure on how to test this.