Adds support for lists in scrubbing logic #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joladev
force-pushed
the
support-lists-in-scrubbing
branch
from
0bc94ac
to
d10a159
Compare
mitchellhenke
suggested changes
Nov 22, 2020
The scrubbing logic acts on keys, and so lists themselves are not a target for scrubbing. But lists can contain maps that need scrubbing. This adds support for lists in the scrubbing logic.
joladev
force-pushed
the
support-lists-in-scrubbing
branch
from
d10a159
to
e47eb6d
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scrubbing logic in
Sentry.PlugContextacts on keys, and so lists themselves are not a target for scrubbing. But lists can contain maps that need scrubbing. This adds support for lists in the scrubbing logic.