Add :remote_address_reader PlugContext option #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mitchellhenke bump |
sl0thentr0py
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on masking user IP from Sentry at work, after scrubbing the IP from headers I noticed that user's IP is also visible under Environment's
REMOTE_ADDR. One way to hide/mask the IP I thought about was to have additional plugs before and afterPlugContext, to change and re-set theconn.remote_ipvalue. But I think a better solution would be to make reading of this value configurable.When working on the patch I noticed the logic on the
masterbranch has changed to read thex-forwarded-forheader when present, so I made this the new default remote address reader.