Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated Mix.Config #555

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Remove use of deprecated Mix.Config #555

merged 1 commit into from
Jul 11, 2023

Conversation

whatyouhide
Copy link
Collaborator

No description provided.

@whatyouhide whatyouhide requested a review from sl0thentr0py July 11, 2023 15:11
@@ -5,6 +5,7 @@ Code.require_file("test/support/test_filter.exs")
Code.require_file("test/support/test_gen_server.exs")
Code.require_file("test/support/test_error_view.exs")

ExUnit.start()
ExUnit.start(assert_receive_timeout: 500)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus thing to remove some config 🙃

@yordis
Copy link
Contributor

yordis commented Jul 11, 2023

Do you need all those config files, btw?

It is a lib so probably only a test environment is needed here (or just config/config.exs, no?

@whatyouhide whatyouhide merged commit 11c2a10 into master Jul 11, 2023
@whatyouhide whatyouhide deleted the al/mix-config branch July 11, 2023 15:52
@whatyouhide
Copy link
Collaborator Author

@yordis yes, that's next step 👍 Unless you wanna get on a PR, I'd be happy to have some help 😄

@yordis
Copy link
Contributor

yordis commented Jul 11, 2023

@whatyouhide count me on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants