Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deprecation of Sentry.Config.root_source_code_path/0 #558

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Improve deprecation of Sentry.Config.root_source_code_path/0 #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/sentry/config.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,14 @@ defmodule Sentry.Config do

@deprecated "Use root_source_code_paths/0 instead"
def root_source_code_path do
path = get_config(:root_source_code_path, check_dsn: false)

if path do
if path = get_config(:root_source_code_path, check_dsn: false) do
path
else
raise ArgumentError.exception(":root_source_code_path must be configured")
raise ArgumentError, """
you called Sentry.Config.root_source_code_path/0, but :root_source_code_path is \
not configured. root_source_code_path/0 is deprecated anyways, so you should \
use root_source_code_paths/0 (plural) instead, and configure :root_source_code_paths.\
"""
end
end

Expand Down