Handle bandit's get peer data exception #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
reviewed
Oct 22, 2024
ardhitama
force-pushed
the
handle-bandit-get-peer-data-exception
branch
2 times, most recently
from
9bbb8d2
to
b3d3c85
Compare
As of bandit v1.5.7 during client disconnection it will raise "Unable to obtain transport_info: [reason]" everytime it tries to get the transport info. This commit tries to handle that exception by returning nil instead of bubbling the exception.
ardhitama
force-pushed
the
handle-bandit-get-peer-data-exception
branch
from
b3d3c85
to
5eb18de
Compare
whatyouhide
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of bandit v1.5.7 during client disconnection it will raise "Unable to obtain transport_info: [reason]" every time it tries to get the transport info. This commit tries to handle that exception by returning nil instead of bubbling the exception.
Context: https://github.com/mtrudel/bandit/blob/b06e43dcee93c5c044b18ed8347838fc2a1728f0/lib/bandit/transport_info.ex#L26