feat: Add support for Dynamic Sampling #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
reviewed
Nov 7, 2022
cleptric
force-pushed
the
dynamic-sampling
branch
from
b9e0a00
to
7ecd814
Compare
kamilogorek
reviewed
Nov 9, 2022
kamilogorek
reviewed
Nov 9, 2022
Co-authored-by: Kamil Ogórek <kamil@sentry.io>
# Conflicts: # sentry.go
Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
cleptric
force-pushed
the
dynamic-sampling
branch
3 times, most recently
from
33562f0
to
f219a81
Compare
Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
AbhiPrasad
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first episode in the series to support Dynamic Sampling in the Go SDK.
baggageheaders and attach the DSC on the transaction. I vendored in the OpenTelemetry baggage implementation from https://github.com/open-telemetry/opentelemetry-goSDKMetaData, a way to pass the DSC from the transaction to the event (similar to PHP & JS)dsn,sdkandtraceI'll use this PR as the base for the whole feature and will branch out from here for the remaining tasks.
Related PRs
Closes #456