Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test sentry-go with Go 1.13, drop Go 1.10 #54

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

rhcarvalho
Copy link
Contributor

Go 1.13 was released 2 days ago. This PR proposes dropping support for Go 1.10 keeping support for the 3 latest releases.

This plus #52 should bring Travis back to green.

Using go1.11, update the list of dependencies and their checksums.
@rhcarvalho
Copy link
Contributor Author

Go 1.13 golangci-lint issues are known and tracked upstream: golangci/golangci-lint#658

FIWI, installing golangci-lint from source instead of the prebuilt release binaries also has known problems with Go 1.13 at the moment: golangci/golangci-lint#652 / golangci/golangci-lint#659

@kamilogorek kamilogorek merged commit d1d6967 into getsentry:master Sep 5, 2019
@kamilogorek
Copy link
Contributor

Thanks for all the awesome PRs @rhcarvalho! I really appreciate it! :)
I'll review the remaining two Today.

@rhcarvalho rhcarvalho deleted the travis-go113 branch September 5, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants