fix: Create a frozen DSC when calling ToBaggage #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.71% // Head: 74.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 74.71% 74.72%
=======================================
Files 38 38
Lines 3837 3838 +1
=======================================
+ Hits 2867 2868 +1
Misses 850 850
Partials 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tonyo
approved these changes
Feb 2, 2023
tonyo
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue, where someone would call
span.ToBaggageto fetch theDynamicSamplingContextto attach it to an outgoing HTTP request "baggage" header or to render it in an HTML template as a "baggage" meta tag before the transaction is finished.We need to freeze the DynamicSamplingContext in such cases, as any mutations after the DynamicSamplingContext was propagated to a downstream SDK mess up DynamicSampling.