Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Add WithTransactionSource() span option, deprecate TransctionSource() #611

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Mar 29, 2023

This deprecates TransctionSource() (which has a typo and therefore might confuse people) in favor of WithTransactionSource(). TransactionSource type already exists, hence the "With" prefix.

TransctionSource() is not removed right away, instead we should add a deprecation note in the changelog of the next release.

NOTE:

  1. Open to alternative suggestions on the name of this span option
  2. For consistency, we might want to prefix all applicable span options with "With". Also, open to discussion.

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up, let's rename all SpanOptions functions to With*.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.03 🎉

Comparison is base (9f9f913) 79.91% compared to head (2849285) 79.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   79.91%   79.94%   +0.03%     
==========================================
  Files          38       38              
  Lines        3873     3875       +2     
==========================================
+ Hits         3095     3098       +3     
  Misses        671      671              
+ Partials      107      106       -1     
Impacted Files Coverage Δ
tracing.go 88.70% <50.00%> (-0.38%) ⬇️
http/sentryhttp.go 87.27% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo tonyo marked this pull request as ready for review April 11, 2023 12:55
@tonyo tonyo merged commit e70db81 into master Apr 11, 2023
@tonyo tonyo deleted the tonyo/with-transaction-source-2 branch April 11, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants