Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix hanging waitgroups #699

Merged
merged 1 commit into from
Aug 14, 2023
Merged

test: fix hanging waitgroups #699

merged 1 commit into from
Aug 14, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Aug 14, 2023

Makes sure wg.Done() is called even if the test code in transport test fails.

With the original code, a test failure in testSendSignalEvent() would result in a timeout because wg.Done() was never called and thus the subsequent wg.Fail() would get blocked indefinitely.

In the new version, the actual test failure will be reported instead.

@vaind vaind requested a review from tonyo August 14, 2023 12:03
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (34ce12e) 80.78% compared to head (7605776) 80.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files          44       44           
  Lines        4466     4466           
=======================================
  Hits         3608     3608           
  Misses        728      728           
  Partials      130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaind vaind merged commit 9f38c57 into master Aug 14, 2023
16 of 17 checks passed
@vaind vaind deleted the test/hanging-waitgroups branch August 14, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants