Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starfish): add http.request.method attribute to span data #786

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Feb 17, 2024

Closes #713

Since existing performance tracing only available on net/http and gin, I only implement http.request.method attribute on those.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (a084ac9) to head (e1010d7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
- Coverage   82.04%   81.97%   -0.08%     
==========================================
  Files          49       49              
  Lines        4846     4848       +2     
==========================================
- Hits         3976     3974       -2     
- Misses        729      732       +3     
- Partials      141      142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505
Copy link
Contributor Author

aldy505 commented Mar 26, 2024

I suppose there'll be a merge conflict, but let's see

@vaind vaind enabled auto-merge (squash) March 26, 2024 15:45
@vaind vaind merged commit 08cdc59 into getsentry:master Mar 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Starfish] Add starfish v1 attribute http.request.method to span data
3 participants