Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zerolog integration #857

Merged
merged 40 commits into from
Nov 14, 2024
Merged

Add Zerolog integration #857

merged 40 commits into from
Nov 14, 2024

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Jul 10, 2024

Resolves #853

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 85.27607% with 24 lines in your changes missing coverage. Please review.

Project coverage is 83.27%. Comparing base (fb01995) to head (bd559f4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
zerolog/sentryzerolog.go 85.27% 16 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   83.21%   83.27%   +0.05%     
==========================================
  Files          54       55       +1     
  Lines        5756     5919     +163     
==========================================
+ Hits         4790     4929     +139     
- Misses        804      820      +16     
- Partials      162      170       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zerolog/zerolog.go Fixed Show fixed Hide fixed
@ribice ribice marked this pull request as ready for review July 20, 2024 14:30
@ribice ribice requested a review from cleptric July 21, 2024 09:51
@antisocrates
Copy link

Will this be available in the next minor release?

@ribice
Copy link
Collaborator Author

ribice commented Oct 21, 2024

Will this be available in the next minor release?

Yes, we plan to include this in next release.

cleptric
cleptric previously approved these changes Oct 29, 2024
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this it's own package. You can update https://github.com/getsentry/sentry-go/blob/master/.craft.yml and I'll add it to our release registry.

cleptric

This comment was marked as duplicate.

@cleptric cleptric dismissed their stale review October 29, 2024 07:55

Meant to comment

@ribice ribice requested a review from cleptric November 13, 2024 22:47
Makefile Outdated Show resolved Hide resolved
@cleptric cleptric enabled auto-merge (squash) November 14, 2024 14:18
@cleptric cleptric merged commit 72d6158 into master Nov 14, 2024
16 checks passed
@cleptric cleptric deleted the zerolog branch November 14, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for zerolog
3 participants