Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slog integration #865

Merged
merged 40 commits into from
Nov 13, 2024
Merged

Add Slog integration #865

merged 40 commits into from
Nov 13, 2024

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Jul 28, 2024

Resolves #527

@ribice ribice requested a review from cleptric July 28, 2024 10:47
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

Attention: Patch coverage is 86.68731% with 43 lines in your changes missing coverage. Please review.

Project coverage is 83.21%. Comparing base (eb74cc1) to head (08340ae).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
slog/common.go 89.13% 16 Missing and 4 partials ⚠️
slog/sentryslog.go 66.66% 14 Missing and 1 partial ⚠️
slog/converter.go 91.48% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage   83.01%   83.21%   +0.20%     
==========================================
  Files          51       54       +3     
  Lines        5433     5756     +323     
==========================================
+ Hits         4510     4790     +280     
- Misses        767      804      +37     
- Partials      156      162       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ribice
Copy link
Collaborator Author

ribice commented Jul 29, 2024

@cleptric Just realised we can't use 1.18 with exp/slog (requires at least 1.19): golang/go#57113

@ribice ribice marked this pull request as ready for review July 31, 2024 15:35
@assembly-winston
Copy link

Will this be merged?

@cleptric
Copy link
Member

cleptric commented Sep 16, 2024

Yes. We're holding off merging new features for a week or so to give us time to fix potential issues in 0.29.0. Afterwards, we'll get this out.

cleptric
cleptric previously approved these changes Oct 29, 2024
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this it's own package. You can update https://github.com/getsentry/sentry-go/blob/master/.craft.yml and I'll add it to our release registry.

@cleptric cleptric dismissed their stale review October 29, 2024 07:55

Meant to comment

@ribice
Copy link
Collaborator Author

ribice commented Nov 5, 2024

Let's make this it's own package. You can update https://github.com/getsentry/sentry-go/blob/master/.craft.yml and I'll add it to our release registry.

I updated .craft.yml and made slog integration a module. Is there anything else that needs to be updated?

CHANGELOG.md Outdated Show resolved Hide resolved
@cleptric
Copy link
Member

cleptric commented Nov 5, 2024

Just CI needs to pass and then we can get this merged 🙂

@ribice
Copy link
Collaborator Author

ribice commented Nov 5, 2024

@cleptric Shall I update the vet script in Makefile to skip if no go files are found (which is the case for slog in Go <1.21 due to build constraints)?

@ribice
Copy link
Collaborator Author

ribice commented Nov 8, 2024

Waiting for #898 to be merged before I merge this.

@ribice ribice requested a review from cleptric November 8, 2024 18:35
@cleptric cleptric merged commit fb01995 into master Nov 13, 2024
16 checks passed
@cleptric cleptric deleted the slog branch November 13, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an exp/slog.Handler
3 participants