Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function grouping prefix fix #877

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Aug 28, 2024

Resolves #712

An alternative is not to have build tags for this, but that means it'll traverse the frames without purpose on Go <1.21.

@ribice ribice requested a review from cleptric August 28, 2024 15:57
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.83%. Comparing base (72f3bff) to head (73df8cd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
- Coverage   82.88%   82.83%   -0.05%     
==========================================
  Files          51       53       +2     
  Lines        4597     4609      +12     
==========================================
+ Hits         3810     3818       +8     
- Misses        634      637       +3     
- Partials      153      154       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric merged commit bff876d into master Sep 3, 2024
25 checks passed
@cleptric cleptric deleted the function-grouping-prefix-fix branch September 3, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.21 has changed function closures names and it disrupts grouping
3 participants