Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard unfinished Spans before sending them over to Sentry #1262

Closed
marandaneto opened this issue Feb 17, 2021 · 2 comments · Fixed by #1279
Closed

Discard unfinished Spans before sending them over to Sentry #1262

marandaneto opened this issue Feb 17, 2021 · 2 comments · Fixed by #1279
Assignees
@maciejwalkowiak
Labels
performance Performance API issues

Comments

@marandaneto
Copy link
Contributor

We need to discard Spans that are unfinished before sending them over to Sentry, the reason is getsentry/develop#274

Relay drops the whole transaction if a single Span is unfinished.

@Tyrrrz @brustolin I believe this is also important for you both
@marandaneto marandaneto added Type: Bug Something isn't working performance Performance API issues labels Feb 17, 2021
@maciejwalkowiak
Copy link
Contributor

When a parent span is not finished, but his child spans are finished, should the parent be removed with children or just a parent and children should stay?

maciejwalkowiak added a commit that referenced this issue Feb 19, 2021
@maciejwalkowiak
Fix: Discard unfinished Spans before sending them over to Sentry
04c874d 
Fixes #1262
@maciejwalkowiak maciejwalkowiak mentioned this issue Feb 19, 2021
Merged
4 tasks
@marandaneto marandaneto mentioned this issue Feb 19, 2021
Closed
@marandaneto
Copy link
Contributor Author

When a parent span is not finished, but his child spans are finished, should the parent be removed with children or just a parent and children should stay?

how is it shown in the UI in such cases? does the transaction still get ingested? does the parentless span gets ingested?

marandaneto added a commit that referenced this issue Feb 22, 2021
@marandaneto
Merge branch 'main' into gh-1262
ac21294
maciejwalkowiak added a commit that referenced this issue Feb 22, 2021
@maciejwalkowiak
Merge branch 'gh-1262' of https://github.com/getsentry/sentry-java into
280b679 
gh-1262
maciejwalkowiak added a commit that referenced this issue Feb 22, 2021
@maciejwalkowiak
Fix: Discard unfinished Spans before sending them over to Sentry (#1279)
b2a4b4d 
Fixes #1262
@stephanie-anderson stephanie-anderson removed the Type: Bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maciejwalkowiak maciejwalkowiak

Labels
performance Performance API issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Discard unfinished Spans before sending them over to Sentry getsentry/sentry-java
3 participants
@maciejwalkowiak @marandaneto @stephanie-anderson