Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry should support multiple debug-meta.properties #2994

Closed
adinauer opened this issue Oct 17, 2023 · 4 comments · Fixed by #3024
Closed

Sentry should support multiple debug-meta.properties #2994

adinauer opened this issue Oct 17, 2023 · 4 comments · Fixed by #3024
Assignees
Labels
enhancement New feature or request Platform: Java

Comments

@adinauer
Copy link
Member

adinauer commented Oct 17, 2023

Problem Statement

In a multi-module build there's one debug-meta.properties per module. Currently we only load the first one and stop.

Solution Brainstorm

Load all we can find at runtime (in that case this issue should probably be moved to sentry-java)
merge them during build

@adinauer adinauer added enhancement New feature or request Platform: Android labels Oct 17, 2023
@adinauer
Copy link
Member Author

The following code could serve as a starter for a workaround for users running into this limitation and wanting to set bundle IDs themselves:

package io.sentry.samples.spring.boot.jakarta;


import org.jetbrains.annotations.NotNull;
import org.springframework.stereotype.Component;

import io.sentry.Sentry;
import io.sentry.SentryOptions;

@Component
public class SentryConfigCustomizer implements Sentry.OptionsConfiguration<SentryOptions> {
  @Override
  public void configure(@NotNull SentryOptions options) {
    // ... load your debug-ids, foreach ...
    options.addBundleId("...");
  }
}

@romtsn
Copy link
Member

romtsn commented Oct 17, 2023

I think we're better off doing this in sentry-java. To merge them from multi-modules, the plugin either will have to be applied to the root project, or to each of the modules, and I think this is gonna be much more work to support multi-module 🤔

@adinauer adinauer transferred this issue from getsentry/sentry-android-gradle-plugin Oct 17, 2023
@adinauer adinauer changed the title SAGP should support multiple debug-meta.properties in a multi-module build Sentry should support multiple debug-meta.properties Oct 17, 2023
@stefanosiano
Copy link
Member

@adinauer This is relevant for backend only, as Android uploads only files from 1 module anyway, correct?

@adinauer
Copy link
Member Author

@stefanosiano afaik yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Platform: Java
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants