fromHttpStatusCode in SpanStatus L79 does not handle 3xx

[mikand13]

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

This is our relevant code:

transaction?.finish(fromHttpStatusCode(status ?: 500))

Expected Result

Would expect this to return an ok spanstatus or something of that order for a 3xx response, 304 f.ex is a very normal cache response, and 301 or 302 is not unusual either, f.ex. in auth apis.

Actual Result

It seems a null SpanStatus is returned which again marks this as a failed transaction. We have a lot of 304 so basically all our requests are tagged as failed giving us a >99 failure rate.

Product Area

APIs

Link

No response

DSN

No response

Version

No response

[getsantry]

Assigning to @getsentry/support for routing ⏲️

[getsantry]

Routing to @getsentry/product-owners-performance for triage ⏲️

[Dhrumil-Sentry]

Hi, this might be related to your SDK setups, what Sentry SDK are you using?

[mikand13]

Most def, the line reference is for the java sdk.

[adinauer]

Thanks for the feedback, not sure why there's a gap in status codes, I'll try to find out and report back.

[adinauer]

Looks like the python SDK considers anything < 400 to be OK for the span status (https://github.com/getsentry/sentry-python/blob/5e2d2cf7fdf367dc3bced0d4c4efe33c1046887c/sentry_sdk/tracing.py#L161-L162).

We can change the Java SDK to also do so.

[mikand13]

@adinauer One might argue that 301, 303 and 307 are responses that expect some kind of change, ie. it is not a successful request, but not sure if that level of detail is necessary.

[adinauer]

Thanks, I'll check with python SDK maintainers if they're aware of any complaints regarding those.

[adinauer]

We have just released 8.0.0-beta.2 of the Java SDK, which now maps status codes below 400 to SpanStatus.OK. If you decide to give it a try, feedback would be great.