Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All status codes below 400 are now mapped to SpanStatus.OK #3869

Merged
merged 12 commits into from
Nov 11, 2024

Conversation

adinauer
Copy link
Member

📜 Description

All status codes below 400 are now mapped to SpanStatus.OK

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 41a916c

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.21 ms 408.46 ms 7.25 ms
Size 1.65 MiB 2.31 MiB 672.90 KiB

Previous results on branch: feat/status-code-mapping-3xx

Startup times

Revision Plain With Sentry Diff
132ee06 404.36 ms 448.06 ms 43.70 ms

App size

Revision Plain With Sentry Diff
132ee06 1.70 MiB 2.36 MiB 671.49 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/potel-55-non-current-span-start-child to 8.x.x November 11, 2024 15:49
@adinauer adinauer merged commit f028e77 into 8.x.x Nov 11, 2024
32 checks passed
@adinauer adinauer deleted the feat/status-code-mapping-3xx branch November 11, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants