Simplify Sentry configuration in Spring integration. #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1259 +/- ##
============================================
+ Coverage 74.91% 75.03% +0.12%
- Complexity 1743 1747 +4
============================================
Files 183 183
Lines 6118 6141 +23
Branches 609 609
============================================
+ Hits 4583 4608 +25
+ Misses 1256 1254 -2
Partials 279 279
Continue to review full report at Codecov.
|
marandaneto
reviewed
Feb 17, 2021
Comment on lines
+48
to
+51
| applicationContext | ||
| .getBeansOfType(EventProcessor.class) | ||
| .values() | ||
| .forEach(options::addEventProcessor); |
There was a problem hiding this comment.
what's about doing the same for List<Integration> integrations?
marandaneto
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Auto-configures user provided callbacks and event processors on
SentryOptionsas well asSentryConfigurationbean.💡 Motivation and Context
Currently there is no straightforward way to configure callbacks and event processors on SentryOptions in Spring integration. With this change, there is a convenient way to set most common callbacks just as Spring beans and if something advanced needs to be configured users can define
SentryConfigurationbeans that post processesSentryOptionsbeforeSentryInitis called.💚 How did you test it?
Integration tests.
📝 Checklist
🔮 Next steps
Update reference docs.