Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable debug mode in Log4j2 integration. #1492

Merged
merged 2 commits into from
May 27, 2021
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Add option to enable debug mode in Log4j2 integration.

💡 Motivation and Context

Fixes #1488
Simplify debugging in cases like https://stackoverflow.com/questions/67690759/why-does-sentry-not-work-with-log4j2-for-me

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #1492 (411cd0a) into main (8010018) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1492   +/-   ##
=========================================
  Coverage     75.65%   75.66%           
  Complexity     1929     1929           
=========================================
  Files           191      191           
  Lines          6598     6600    +2     
  Branches        666      666           
=========================================
+ Hits           4992     4994    +2     
  Misses         1280     1280           
  Partials        326      326           
Impacted Files Coverage Δ
...src/main/java/io/sentry/log4j2/SentryAppender.java 85.18% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8010018...411cd0a. Read the comment docs.

@marandaneto marandaneto merged commit d58fbdb into main May 27, 2021
@marandaneto marandaneto deleted the gh-1488 branch May 27, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to enable debug mode in Log4j2 integration
3 participants