Fix: set min sdk version of sentry-android-fragment to API 14 #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
requested review from
bruno-garcia and
maciejwalkowiak
as code owners
marandaneto
commented
Jul 19, 2021
marandaneto
commented
Jul 19, 2021
marandaneto
commented
Jul 19, 2021
| @@ -86,7 +85,7 @@ object Config { | |||
|
|
|||
| val coroutinesCore = "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.4.3" | |||
|
|
|||
| val fragment = "androidx.fragment:fragment-ktx:1.3.4" | |||
| val fragment = "androidx.fragment:fragment-ktx:1.3.5" | |||
There was a problem hiding this comment.
theres a critical bugfix from 1.3.4
Codecov Report
@@ Coverage Diff @@
## main #1608 +/- ##
=========================================
Coverage 76.07% 76.07%
Complexity 1976 1976
=========================================
Files 198 198
Lines 6842 6842
Branches 680 680
=========================================
Hits 5205 5205
Misses 1305 1305
Partials 332 332 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
https://mvnrepository.com/artifact/androidx.fragment/fragment and https://androidx.tech/artifacts/fragment/fragment/ state min API 14
💡 Motivation and Context
Fix #1607
💚 How did you test it?
CI
📝 Checklist
🔮 Next steps