Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove onActivityPreCreated call in favor of onActivityCreated (#1661) #1661

Merged
merged 10 commits into from
Aug 19, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Aug 19, 2021

  • Remove onActivityPreCreated and use onActivityCreated
  • changelog

📜 Description

💡 Motivation and Context

Fix #1659

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title fix/activity frame Fix: Remove onActivityPreCreated call in favor of onActivityCreated (#1661) Aug 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1661 (7948467) into main (bcdb061) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1661   +/-   ##
=========================================
  Coverage     75.77%   75.77%           
  Complexity     2019     2019           
=========================================
  Files           207      207           
  Lines          7045     7045           
  Branches        699      699           
=========================================
  Hits           5338     5338           
  Misses         1369     1369           
  Partials        338      338           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcdb061...7948467. Read the comment docs.

@marandaneto marandaneto merged commit 41654d8 into main Aug 19, 2021
@marandaneto marandaneto deleted the fix/activity-frame branch August 19, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActivityFrameTracker breaks runtime theme changing.
2 participants