Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: drop spans in BeforeSpanCallback. #1713

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Fix: drop spans in BeforeSpanCallback. #1713

merged 2 commits into from
Sep 14, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Sep 14, 2021

📜 Description

Fix: drop spans in BeforeSpanCallback. #1713

💡 Motivation and Context

Fixes #1708

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

#skip-changelog

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review September 14, 2021 10:19
@codecov-commenter
Copy link

Codecov Report

Merging #1713 (2b6da6a) into main (21b6126) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1713      +/-   ##
============================================
+ Coverage     75.07%   75.08%   +0.01%     
- Complexity     2098     2099       +1     
============================================
  Files           211      211              
  Lines          7506     7511       +5     
  Branches        789      790       +1     
============================================
+ Hits           5635     5640       +5     
  Misses         1490     1490              
  Partials        381      381              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SpanContext.java 93.75% <ø> (ø)
...in/java/io/sentry/openfeign/SentryFeignClient.java 96.22% <100.00%> (+0.30%) ⬆️
...ain/java/io/sentry/protocol/SentryTransaction.java 92.68% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b6126...2b6da6a. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit 11c2c37 into main Sep 14, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1708 branch September 14, 2021 11:55
@marandaneto
Copy link
Contributor

this one should have a changelog since beta.1 has been published, adding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BeforeSpanCallback isnt dropping spans
3 participants