Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Timber throwing on args usage #1986

Merged
merged 3 commits into from
Apr 13, 2022
Merged

fix: Timber throwing on args usage #1986

merged 3 commits into from
Apr 13, 2022

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 12, 2022

📜 Description

💡 Motivation and Context

Closes #1985

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@romtsn romtsn requested a review from marandaneto as a code owner April 12, 2022 22:07
@bruno-garcia
Copy link
Member

That's late mate 😅

@bruno-garcia
Copy link
Member

Sounds like a good patch to ship asap

@romtsn romtsn merged commit f0786d3 into main Apr 13, 2022
@romtsn romtsn deleted the fix/timber-crash branch April 13, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@marandaneto marandaneto Awaiting requested review from marandaneto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry 5.7.2 with timber integration crashes the app when formats a message with args
3 participants
@romtsn @bruno-garcia @getsentry-bot