Improve jul sample for easier debugging inside IDE #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changelog need here i guess, correct? |
maciejwalkowiak
approved these changes
May 19, 2022
| import java.util.logging.Logger; | ||
| import org.slf4j.MDC; | ||
|
|
||
| public class Main { | ||
|
|
||
| private static final Logger LOGGER = Logger.getLogger(Main.class.getName()); | ||
|
|
||
| public static void main(String[] args) { | ||
| public static void main(String[] args) throws Exception { | ||
| LogManager.getLogManager() |
There was a problem hiding this comment.
I think there should be a comment that this is made only for the purpose of running it from an IDE.
There was a problem hiding this comment.
Added a comment for an alternative way of providing the logging.properties file.
Codecov Report
@@ Coverage Diff @@
## 6.x.x #2058 +/- ##
========================================
Coverage ? 80.87%
Complexity ? 3176
========================================
Files ? 228
Lines ? 11736
Branches ? 1576
========================================
Hits ? 9492
Misses ? 1655
Partials ? 589 Continue to review full report at Codecov.
|
maciejwalkowiak
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Improve jul sample for easier debugging inside IDE
💡 Motivation and Context
This way it's easier to start from IDE in debugging mode. Code before didn't use
logging.propertiesin that case and handler also wasn't used when starting from IDE.Also replaced logback dependency with slf4j to get access to
MDC.💚 How did you test it?
locally
📝 Checklist
🔮 Next steps
#skip-changelog