feat: Add sentry-android-navigation module #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
romtsn
commented
Jun 20, 2022
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Outdated
Show resolved
Hide resolved
romtsn
commented
Jun 20, 2022
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Outdated
Show resolved
Hide resolved
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Outdated
Show resolved
Hide resolved
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Show resolved
Hide resolved
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Outdated
Show resolved
Hide resolved
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Show resolved
Hide resolved
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Outdated
Show resolved
Hide resolved
Is it good or bad? 🙈 haha |
|
@adinauer add you to keep you in the loop, feel free to delegate to Lukas if you think it's better |
marandaneto
reviewed
Jun 22, 2022
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Show resolved
Hide resolved
marandaneto
reviewed
Jun 22, 2022
Codecov Report
@@ Coverage Diff @@
## feat/compose-navigation-support #2116 +/- ##
==================================================================
Coverage 80.94% 80.94%
Complexity 3254 3254
==================================================================
Files 231 231
Lines 11952 11952
Branches 1586 1586
==================================================================
Hits 9674 9674
Misses 1698 1698
Partials 580 580
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Before we can release this we need to add to .craft.yml in this repo, and https://github.com/getsentry/sentry-release-registry
|
@bruno-garcia noted thanks |
9 tasks
adinauer
approved these changes
Jun 23, 2022
...ry-android-navigation/src/main/java/io/sentry/android/navigation/SentryNavigationListener.kt
Show resolved
Hide resolved
philipphofmann
approved these changes
Jun 23, 2022
...ndroid-navigation/src/test/java/io/sentry/android/navigation/SentryNavigationListenerTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
sentry-android-navigationmodule to support androidx.navigation library (only breadcrumbs for now)This is part of the Jetpack Compose Navigation support.
💡 Motivation and Context
Part of #2096
💚 How did you test it?
📝 Checklist
🔮 Next steps