Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use reusable Danger workflow #2253

Merged
merged 1 commit into from
Sep 21, 2022
Merged

ci: use reusable Danger workflow #2253

merged 1 commit into from
Sep 21, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Sep 21, 2022

Reuses a common Danger workflow. Compared to the current version in this repo, it also recognizes "ci:" & "chore(deps):" title prefixes which causes it to skip the changelog check.

Additionally, new checks that will later be added to the shared dangerfile will automatically propagate to all the repos.

@vaind vaind changed the title chore: use reusable Danger workflow ci: use reusable Danger workflow Sep 21, 2022
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 337.98 ms 369.91 ms 31.94 ms
Size 1.74 MiB 2.33 MiB 604.92 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d89dea 322.38 ms 350.82 ms 28.45 ms
3d89dea 345.59 ms 364.06 ms 18.47 ms

App size

Revision Plain With Sentry Diff
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB
3d89dea 1.74 MiB 2.33 MiB 604.92 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@vaind vaind merged commit 1e4690d into main Sep 21, 2022
@vaind vaind deleted the chore/reuse-danger branch September 21, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants