Fix performance collector setup called in main thread #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sentry/src/main/java/io/sentry/TransactionPerformanceCollector.java # sentry/src/test/java/io/sentry/TransactionPerformanceCollectorTest.kt
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
adinauer
approved these changes
Jan 26, 2023
Performance metrics 🚀
|
Codecov ReportBase: 80.12% // Head: 80.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2499 +/- ##
=========================================
Coverage 80.12% 80.12%
+ Complexity 3920 3919 -1
=========================================
Files 322 322
Lines 14793 14796 +3
Branches 1951 1951
=========================================
+ Hits 11853 11856 +3
Misses 2171 2171
Partials 769 769
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
DefaultTransactionPerformanceCollector was calling setup() on main thread, and we moved it to a background thread.
💡 Motivation and Context
Since one of the collectors reads files during setup(), calling it in the main thread would make Android complain if strict mode is applied.
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps