-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use daemon threads for SentryExecutorService #2747
Merged
adinauer
merged 4 commits into
main
from
fix/use-daemon-threads-for-sentry-executor-service
May 30, 2023
Merged
Use daemon threads for SentryExecutorService #2747
adinauer
merged 4 commits into
main
from
fix/use-daemon-threads-for-sentry-executor-service
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
16cd2b6 | 243.02 ms | 349.69 ms | 106.67 ms |
46b1782 | 387.72 ms | 458.74 ms | 71.02 ms |
1707044 | 338.80 ms | 384.79 ms | 46.00 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
16cd2b6 | 1.72 MiB | 2.28 MiB | 570.95 KiB |
46b1782 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
1707044 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
Previous results on branch: fix/use-daemon-threads-for-sentry-executor-service
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
24917e3 | 313.12 ms | 345.75 ms | 32.63 ms |
60431b9 | 294.82 ms | 338.18 ms | 43.36 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
24917e3 | 1.72 MiB | 2.28 MiB | 571.10 KiB |
60431b9 | 1.72 MiB | 2.28 MiB | 571.10 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2747 +/- ##
============================================
+ Coverage 81.09% 81.10% +0.01%
+ Complexity 4470 4455 -15
============================================
Files 347 344 -3
Lines 16472 16423 -49
Branches 2232 2227 -5
============================================
- Hits 13358 13320 -38
+ Misses 2181 2174 -7
+ Partials 933 929 -4
☔ View full report in Codecov by Sentry. |
romtsn
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
We're now passing a
ThreadFactory
that sets daemon totrue
so threads will no longer block shutdown.💡 Motivation and Context
Fixes #2744
💚 How did you test it?
Manually using Logback sample.
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps