-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slow/frozen frames were not reported with transactions #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c03a05e | 390.40 ms | 419.35 ms | 28.94 ms |
dc67004 | 273.86 ms | 346.37 ms | 72.51 ms |
9246ed4 | 275.63 ms | 321.31 ms | 45.69 ms |
496bdfd | 301.22 ms | 343.96 ms | 42.73 ms |
8820c5c | 330.60 ms | 416.86 ms | 86.26 ms |
0310da5 | 381.20 ms | 404.50 ms | 23.30 ms |
496bdfd | 272.86 ms | 407.33 ms | 134.48 ms |
9246ed4 | 281.79 ms | 352.08 ms | 70.29 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c03a05e | 1.72 MiB | 2.29 MiB | 574.43 KiB |
dc67004 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
8820c5c | 1.72 MiB | 2.28 MiB | 571.82 KiB |
0310da5 | 1.72 MiB | 2.28 MiB | 573.45 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
Previous results on branch: rz/fix/slow-frozen-frames
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33a0ed5 | 297.79 ms | 313.58 ms | 15.80 ms |
c1ac8b7 | 274.37 ms | 317.44 ms | 43.07 ms |
79e7a47 | 323.68 ms | 328.87 ms | 5.19 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
33a0ed5 | 1.72 MiB | 2.29 MiB | 575.02 KiB |
c1ac8b7 | 1.72 MiB | 2.29 MiB | 575.02 KiB |
79e7a47 | 1.72 MiB | 2.29 MiB | 575.02 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
============================================
+ Coverage 81.25% 81.27% +0.01%
- Complexity 4560 4562 +2
============================================
Files 350 350
Lines 16870 16871 +1
Branches 2274 2274
============================================
+ Hits 13708 13712 +4
+ Misses 2219 2216 -3
Partials 943 943
☔ View full report in Codecov by Sentry. |
stefanosiano
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
We were setting the
transactionFinishedCallback
totransactionOptions
, but were never calling it💡 Motivation and Context
Internal discussions
💚 How did you test it?
Manually and automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps