Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tests on saucelabs are now selected based on OS version only #2867

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Jul 26, 2023

📜 Description

ui tests on saucelabs now are selected based on OS version only
#skip-changelog

💡 Motivation and Context

We don't care about the specific device the tests run on, only the OS version, contrary to benchmarks.
This will improve saucelabs faults due to a specific device being already in use when we try to run a test.

💚 How did you test it?

🙃

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (87b3774) 81.38% compared to head (5be0930) 81.38%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2867   +/-   ##
=========================================
  Coverage     81.38%   81.38%           
  Complexity     4645     4645           
=========================================
  Files           354      354           
  Lines         17114    17114           
  Branches       2313     2313           
=========================================
  Hits          13928    13928           
  Misses         2236     2236           
  Partials        950      950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanosiano stefanosiano enabled auto-merge (squash) July 26, 2023 16:44
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@stefanosiano stefanosiano merged commit fe10f05 into main Jul 27, 2023
18 checks passed
@stefanosiano stefanosiano deleted the tests/avoid-specific-device-saucelabs branch July 27, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants