-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for sending checkins (CRONS) manually #2935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f274c79 | 334.86 ms | 348.54 ms | 13.68 ms |
9e60fc1 | 310.37 ms | 359.48 ms | 49.11 ms |
9e60fc1 | 309.74 ms | 362.30 ms | 52.56 ms |
adf8fe3 | 300.49 ms | 357.36 ms | 56.87 ms |
9e60fc1 | 331.71 ms | 374.28 ms | 42.57 ms |
f60279b | 324.60 ms | 345.33 ms | 20.73 ms |
f274c79 | 313.96 ms | 355.96 ms | 42.00 ms |
fe10f05 | 314.71 ms | 360.62 ms | 45.90 ms |
9246ed4 | 281.79 ms | 352.08 ms | 70.29 ms |
695d3a3 | 300.98 ms | 376.90 ms | 75.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
9e60fc1 | 1.72 MiB | 2.29 MiB | 575.91 KiB |
9e60fc1 | 1.72 MiB | 2.29 MiB | 575.91 KiB |
adf8fe3 | 1.72 MiB | 2.29 MiB | 575.24 KiB |
9e60fc1 | 1.72 MiB | 2.29 MiB | 575.91 KiB |
f60279b | 1.72 MiB | 2.29 MiB | 575.23 KiB |
f274c79 | 1.72 MiB | 2.29 MiB | 575.01 KiB |
fe10f05 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
695d3a3 | 1.72 MiB | 2.29 MiB | 575.53 KiB |
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job 👍
Left some comments
|
||
private @Nullable Map<String, Object> unknown; | ||
|
||
public CheckIn(String monitorSlug, CheckInStatus status) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constructor Params should be @NotNull
annotated and final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in a follow up PR.
} | ||
|
||
@ApiStatus.Internal | ||
public CheckIn(SentryId checkInId, String monitorSlug, String status) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above @NotNull
annotations and final
for the params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in a follow up PR.
SentryEnvelopeItem.fromCheckIn(options.getSerializer(), checkIn); | ||
envelopeItems.add(checkInItem); | ||
|
||
// TODO do we need trace context? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that already decided? If so, we can remove the TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, shouldn't hurt to add it. Will do. Maybe in a follow up PR.
📜 Description
Add API for sending checkins (CRONS) manually.
Simplest usage looks like:
💡 Motivation and Context
One of the parts required for #2875
💚 How did you test it?
Manually, automated tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps