Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ui and unit tests #2992

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Improve ui and unit tests #2992

merged 1 commit into from
Oct 18, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

removed ui test EnvelopeTests.checkProfileNotSentIfEmpty. Added unit test with same goal: SentryEnvelopeItemTest.fromProfilingTrace with empty file throws
added description messages to eventually failing benchmark tests
added small sleeps in SentryWrapperTest to avoid race conditions

#skip-changelog

💡 Motivation and Context

This should greatly reduce CI flakyness

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…test with same goal: SentryEnvelopeItemTest.fromProfilingTrace with empty file throws

added description messages to eventually failing benchmark tests
added small sleeps in SentryWrapperTest to avoid race conditions
@stefanosiano stefanosiano marked this pull request as ready for review October 17, 2023 09:52
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 409.90 ms 461.28 ms 51.38 ms
Size 1.72 MiB 2.29 MiB 576.40 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
c7e2fbc 377.85 ms 426.35 ms 48.50 ms

App size

Revision Plain With Sentry Diff
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for doing this!

@stefanosiano stefanosiano merged commit 12704a9 into main Oct 18, 2023
@stefanosiano stefanosiano deleted the tests/improve-unit-ui-tests branch October 18, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants