-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use getMyMemoryState()
instead of getRunningAppProcesses()
#3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etMyMemoryState instead
romtsn
requested review from
adinauer,
stefanosiano and
markushi
as code owners
October 20, 2023 20:23
romtsn
changed the title
Use
Use Oct 20, 2023
ActivityManager.getMyMemoryState();
instead of ActivityManager.getRunningAppProcesses()
to prevent some app stores from flagging apps as violating privacies.getMyMemoryState()
instead of getRunningAppProcesses()
to prevent some app stores from flagging apps as violating privacies.
romtsn
changed the title
Use
Use Oct 20, 2023
getMyMemoryState()
instead of getRunningAppProcesses()
to prevent some app stores from flagging apps as violating privacies.getMyMemoryState()
instead of getRunningAppProcesses()
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6a40795 | 370.00 ms | 437.33 ms | 67.33 ms |
6684058 | 414.76 ms | 511.46 ms | 96.70 ms |
db8763d | 386.60 ms | 453.66 ms | 67.06 ms |
ff784c6 | 388.51 ms | 461.90 ms | 73.39 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6a40795 | 1.72 MiB | 2.26 MiB | 550.26 KiB |
6684058 | 1.72 MiB | 2.26 MiB | 550.19 KiB |
db8763d | 1.72 MiB | 2.26 MiB | 550.22 KiB |
ff784c6 | 1.72 MiB | 2.26 MiB | 550.22 KiB |
Previous results on branch: rz/fix/running-processes
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6bfbb73 | 400.66 ms | 478.04 ms | 77.38 ms |
422d8cb | 375.00 ms | 463.92 ms | 88.92 ms |
e16f9ae | 355.59 ms | 421.61 ms | 66.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6bfbb73 | 1.72 MiB | 2.26 MiB | 550.29 KiB |
422d8cb | 1.72 MiB | 2.26 MiB | 550.29 KiB |
e16f9ae | 1.72 MiB | 2.26 MiB | 550.29 KiB |
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
looks good!
|
sentry-android-okhttp/src/main/java/io/sentry/android/okhttp/SentryOkHttpInterceptor.kt
Show resolved
Hide resolved
stefanosiano
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use
ActivityManager.getMyMemoryState();
instead ofActivityManager.getRunningAppProcesses()
to retrieve process importance to prevent some app stores from flagging apps as violating privacies.The PR is targeting v7 because
getMyMemoryState
requires API 16, and we bumped it to 19 in v7.💡 Motivation and Context
Closes #2187
💚 How did you test it?
Automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps