Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debugmeta): Add getProguardUuid #3054

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

krystofwoldrich
Copy link
Member

📜 Description

This PR exposes funtion which retrieves the proguard uuid property.

💡 Motivation and Context

This will be used by Hybdrid SDKs.

💚 How did you test it?

RN sample app

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ced0387

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 372.82 ms 456.40 ms 83.58 ms
Size 1.72 MiB 2.29 MiB 578.15 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
99a51e2 405.11 ms 479.65 ms 74.54 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
a3c77bc 375.80 ms 445.85 ms 70.06 ms
93a76ca 378.48 ms 451.78 ms 73.30 ms
c3f503e 360.41 ms 434.67 ms 74.27 ms
93a76ca 397.30 ms 455.16 ms 57.87 ms
3d8bd2b 364.76 ms 469.98 ms 105.22 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms

App size

Revision Plain With Sentry Diff
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
a3c77bc 1.72 MiB 2.29 MiB 577.53 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
c3f503e 1.72 MiB 2.29 MiB 577.04 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit 8d1b70a into main Nov 20, 2023
21 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-add-get-proguard-uuid branch November 20, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants