Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure serialVersionUID of Exception classes are unique #3115

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Conversation

markushi
Copy link
Member

📜 Description

Exceptions implement Serializable, thus it's a good pratice to give serialVersionUID a unique value.

This may helps with regard to code obfuscation too, as we've seen customer reports where Exception subclasses with the same fields get merged into a single class, giving confusing de-obfuscated results.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 429.08 ms 524.86 ms 95.78 ms
Size 1.72 MiB 2.27 MiB 558.28 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8838e01 387.41 ms 467.00 ms 79.59 ms
4e260b3 384.08 ms 477.56 ms 93.48 ms
93a76ca 377.41 ms 448.22 ms 70.81 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
86f0096 368.63 ms 446.92 ms 78.29 ms
0404ea3 332.47 ms 401.12 ms 68.66 ms
b172d4e 412.60 ms 492.68 ms 80.08 ms
93a76ca 397.30 ms 455.16 ms 57.87 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms
7eccfdb 389.94 ms 461.29 ms 71.35 ms

App size

Revision Plain With Sentry Diff
8838e01 1.72 MiB 2.29 MiB 578.15 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB
7eccfdb 1.72 MiB 2.27 MiB 556.93 KiB

Previous results on branch: fix/serialuids

Startup times

Revision Plain With Sentry Diff
c689320 395.92 ms 465.13 ms 69.20 ms
45b223e 392.83 ms 454.94 ms 62.10 ms

App size

Revision Plain With Sentry Diff
c689320 1.72 MiB 2.27 MiB 558.28 KiB
45b223e 1.72 MiB 2.27 MiB 558.28 KiB

@markushi markushi merged commit 8952d0f into main Dec 27, 2023
19 checks passed
@markushi markushi deleted the fix/serialuids branch December 27, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants