Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid concurrency in AndroidProfiler performance data collection #3130

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

stefanosiano
Copy link
Member

📜 Description

put list for loop in synchronized block in AndroidProfiler

💡 Motivation and Context

Fixes #3119

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review January 8, 2024 10:49
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 373.77 ms 451.08 ms 77.31 ms
Size 1.72 MiB 2.27 MiB 558.56 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
937879e 417.64 ms 550.45 ms 132.81 ms
93a76ca 377.41 ms 448.22 ms 70.81 ms
4e260b3 384.08 ms 477.56 ms 93.48 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
937879e 400.98 ms 482.84 ms 81.86 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms
93a76ca 378.48 ms 451.78 ms 73.30 ms
d6d2b2e 392.55 ms 467.50 ms 74.95 ms
86f0096 368.63 ms 446.92 ms 78.29 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms

App size

Revision Plain With Sentry Diff
937879e 1.72 MiB 2.27 MiB 558.42 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
937879e 1.72 MiB 2.27 MiB 558.42 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
d6d2b2e 1.72 MiB 2.27 MiB 555.05 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB

@stefanosiano stefanosiano merged commit eecfab6 into main Jan 8, 2024
20 checks passed
@stefanosiano stefanosiano deleted the fix/profiler-collection-data-concurrency branch January 8, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AndroidTransactionProfiler Crash
2 participants