Move NDK from sentry-java to sentry-native #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Mar 6, 2024
markushi
changed the title
romtsn
reviewed
May 15, 2024
sentry-android-ndk/build.gradle.kts
Outdated
| @@ -101,6 +71,8 @@ dependencies { | |||
| api(projects.sentry) | |||
| api(projects.sentryAndroidCore) | |||
|
|
|||
| implementation("io.sentry:sentry-native-ndk:0.7.20") | |||
There was a problem hiding this comment.
we'll probably need to make our dependency updater work for this module too
romtsn
reviewed
May 15, 2024
| @@ -7,7 +7,7 @@ public final class io/sentry/android/ndk/BuildConfig { | |||
| } | |||
|
|
|||
| public final class io/sentry/android/ndk/DebugImagesLoader : io/sentry/android/core/IDebugImagesLoader { | |||
| public fun <init> (Lio/sentry/android/core/SentryAndroidOptions;Lio/sentry/android/ndk/NativeModuleListLoader;)V | |||
| public fun <init> (Lio/sentry/android/core/SentryAndroidOptions;Lio/sentry/ndk/NativeModuleListLoader;)V | |||
There was a problem hiding this comment.
This smells like a breaking change - should we make it part of v8 actually?
romtsn
approved these changes
May 15, 2024
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a373f02 | 372.81 ms | 432.96 ms | 60.15 ms |
| 3e1e45b | 373.72 ms | 439.33 ms | 65.60 ms |
| dcad3c9 | 400.04 ms | 479.67 ms | 79.62 ms |
| 6f16882 | 426.16 ms | 494.15 ms | 67.99 ms |
| 9f2c855 | 424.20 ms | 506.34 ms | 82.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a373f02 | 1.70 MiB | 2.28 MiB | 596.35 KiB |
| 3e1e45b | 1.70 MiB | 2.28 MiB | 596.32 KiB |
| dcad3c9 | 1.70 MiB | 2.28 MiB | 596.35 KiB |
| 6f16882 | 1.70 MiB | 2.28 MiB | 596.37 KiB |
| 9f2c855 | 1.70 MiB | 2.28 MiB | 596.32 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Relevant
sentry-nativePR: getsentry/sentry-native#944To make this branch work, you need to publish the sentry-native ndk artifact first:
cd sentry-native/ndk./gradlew :lib:publishToMavenLocal💡 Motivation and Context
Move NDK code over to sentry-native, to make it more testable and robust.
💚 How did you test it?
It's reusing the existing tests.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps