Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old profiles deletion on SDK init #3216

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

stefanosiano
Copy link
Member

📜 Description

profiles deleted on init now need to be at least 5 minutes older than the class creation time to account for app start profiles

💡 Motivation and Context

App start profiles could have a lower timestamp than the class creation, resulting in the SDK deleting the app start profile during init

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review February 21, 2024 12:16
@stefanosiano stefanosiano marked this pull request as draft February 21, 2024 12:26
Copy link
Contributor

github-actions bot commented Feb 21, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 362.35 ms 451.37 ms 89.02 ms
Size 1.70 MiB 2.28 MiB 587.88 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1ae2ec6 353.85 ms 419.71 ms 65.85 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
1f3652d 361.62 ms 424.76 ms 63.14 ms
86f0096 371.86 ms 439.78 ms 67.92 ms
8fd337b 349.16 ms 459.22 ms 110.06 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms
7eccfdb 366.98 ms 440.27 ms 73.29 ms
95a98b5 379.14 ms 420.80 ms 41.66 ms
d6d2b2e 463.14 ms 545.56 ms 82.42 ms
8838e01 367.65 ms 447.40 ms 79.75 ms

App size

Revision Plain With Sentry Diff
1ae2ec6 1.70 MiB 2.27 MiB 584.63 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
1f3652d 1.72 MiB 2.27 MiB 554.95 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
8fd337b 1.72 MiB 2.27 MiB 555.00 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB
7eccfdb 1.72 MiB 2.27 MiB 556.93 KiB
95a98b5 1.70 MiB 2.27 MiB 586.31 KiB
d6d2b2e 1.72 MiB 2.27 MiB 555.05 KiB
8838e01 1.72 MiB 2.29 MiB 578.15 KiB

Previous results on branch: fix/delete-older-profiles-init

Startup times

Revision Plain With Sentry Diff
7822bb2 439.25 ms 512.11 ms 72.86 ms

App size

Revision Plain With Sentry Diff
7822bb2 1.70 MiB 2.28 MiB 587.88 KiB

@stefanosiano stefanosiano marked this pull request as ready for review February 21, 2024 12:43
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanosiano stefanosiano enabled auto-merge (squash) February 21, 2024 13:44
@stefanosiano stefanosiano merged commit c34791a into main Feb 21, 2024
24 checks passed
@stefanosiano stefanosiano deleted the fix/delete-older-profiles-init branch February 21, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants